Update signedAuthToken when invoke setAuthToken#30
Closed
BojDom wants to merge 1 commit into
Closed
Conversation
jondubois
reviewed
Sep 19, 2018
| var tokenData = { | ||
| token: signedToken | ||
| }; | ||
| self.signedAuthToken = signedToken |
Member
There was a problem hiding this comment.
This part of the code could potentially be executed asynchronously, that means that it's possible that the socket.authToken could have been unset (or changed) while the original token was being still being signed. So it's good to add an extra if statement to check this. Also, missing semicolon.
Member
|
Thanks for raising this issue and proposing a fix. I've made the complete fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.