remove dep 'component-emitter'

[initial-wu]

No description provided.

[jondubois]

@initial-wu I had to roll back this change because sc-channel is a dependency of SC on both the client and server-side and it inherits from component-emitter (since EventEmitter cannot be used on the client-side). So for consistency I think we should stick with component-emitter for now.

Is there a technical reason why you want to remove component-emitter as a dependency?
It's possible (and worth considering) but it will be more work.

[initial-wu]

socketcluster-server/scserver.js

Line 4 in b8b0bed

var EventEmitter = require('events').EventEmitter;

[jondubois]

@initial-wu Right now the philosophy is that front-end and isomorphic modules inherit from the component-emitter Emitter (regardless of if they are running on the client or server) but pure server-side modules inherit from EventEmitter.

The server-side SCSocket is not strictly an isomorphic module but because it shares a lot of functionality with the client-side SCSocket (which is isomorphic), I thought it would be best if they are consistent.

That said, I think the way things are right now is definitely confusing... Maybe we should split up the sc-channel module into two separate ones; client and server versions; that way the SCChannel doesn't need to be isomorphic and that lets us be more consistent (use EventEmitter everywhere on the backend and Emitter everywhere on the frontend).

Note that this is still slightly confusing because client-side != frontend (e.g. you can run socketcluster-client inside Node.js on the backend)... But I guess it's less confusing.

Dynamically checking if the module is running in the browser vs server at runtime (and requiring Emitter vs EventEmitter based on that) is likely to be messy.