Repository navigation
feat/peptide calculator - #246
Merged
Merged
Conversation
…lose the locale type
…arators and attribution-safe url
…e callout with the cake
…s to water volume
Replaces the split desktop/mobile rendering with one layout served at every width. The settings stack their question above their options, the syringes are a snap rail, and the result is a docked sheet rather than an inline panel plus a floating pill. Every `sm:` override in the widget is gone, so there is one layout to design, translate and reason about instead of two. ResultPanel and StickyResultBar are no longer rendered. Also fixes a horizontal page scroll on narrow viewports. The syringe rail is a `<fieldset>`, and the UA default `min-inline-size: min-content` kept it 472px wide inside a 372px parent, so `overflow-x-auto` never engaged and the document scrolled sideways instead of the rail. `min-w-0` restores the intended behaviour: 91px of page overflow at 390px becomes 0, with 100px of rail scrolling inside its own box.
The nav was `relative` above 640px, so on desktop it sat at the end of the document and only became visible after scrolling all the way down. It is now fixed to the viewport at every width, as it already was on mobile, with the content padded to clear it. It is constrained to the app shell's width rather than stretched with `left-0 right-0`, which would have spanned the whole desktop viewport, ad columns included. This is shared chrome: it changes the desktop layout of every page in the (app) group, not just the calculators.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The `ignores` array lived in a config object that also carried `files`, which in flat config only excludes paths from that one object — it is not a project-wide ignore. So ESLint linted its own config file (reporting `import/no-unresolved` on `typescript-eslint`, which is installed), linted `public/sw.js` with the TS parser that cannot find it in any tsconfig, and locally walked `.next` until it never returned. CI never saw the last one because it lints before building. The ignores now sit in an object of their own. `react/no-unknown-property` gains an ignore list for `jsx` and `global`: they are styled-jsx props on its <style> tags, not misspelt DOM attributes. The two `eslint-disable @next/next/no-img-element` directives named a rule that does not exist in this config — the plugin is registered as `next`. Renaming them made ESLint report both as unused, since the rule is not enabled anywhere, so they are removed. The <img> elements are real but nothing currently checks them.
Mechanical only, produced by `eslint . --fix` once the config's ignore list was made global: import order and group spacing, unused `React` imports removed under the new JSX transform, and two SVG attributes moved from kebab-case to camelCase. No behavioural change. 176 files, and none of them under the peptide calculator, which was already clean. Takes the repo from 319 errors to 0. The 11 remaining warnings are pre-existing unused variables and over-long lines in workout-builder; `pnpm lint` does not fail on warnings.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
📋 Checklist
🗃️ Prisma Migrations (if applicable)
📸 Screenshots (if applicable)
🔗 Related Issues