Repository navigation
Conversation
Drakulix
reviewed
Oct 12, 2026
|
|
||
| wl_output.done(); | ||
| // wl_output.done() only exists since wl_output version 2 | ||
| if wl_output.version() >= 2 { |
Member
There was a problem hiding this comment.
Remove the comment and import/use the self-explaining wayland_server::protocol::wl_output::EVT_DONE_SINCE instead please.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
XdgOutput::add_instance, only sendwl_output.done()to clients that bind to version 2 of wl_output at least.Clients using version 1 (e.g. GTK3 apps) without a
donelistener will crash with the following error otherwise:Observed with the Immersed desktop app on niri, and the same abort is reported against cosmic-comp in pop-os/cosmic-epoch#1137.
I also have a repro harness if interested.
(Disclaimer: I used an AI harness in order to find the problem and suggest a fix.)
Checklist