Add support for newer versions and upgrade to Java 21#4348
Open
intisy wants to merge 157 commits into
Open
Conversation
into stable Conflicts: src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/generators/SolarGenerator.java
…all, bump github-gradle 1.8.3 - byte-swap slimefun4->slimefun5 in copied addon jars (shaded metrics module the source patch can't reach) - githubImplementation dough :all (multi-module), drop mockbukkit, disable tests on Java-8 toolchain
…lel branch lookup
- NbtItemCompat writes/reads the id via CraftMetaItem unhandledTags reflectively, so identity survives renames and lore edits - CustomItemDataService falls back to it when PdcCompat.isSupported() is false; the PDC path is unchanged on 1.14+
…e-1.13 - HashedArmorpiece referenced org.bukkit.inventory.meta.Damageable (1.13+), crashing SlimefunArmorTask with NoClassDefFoundError on 1.8 - normalize durability via reflective setDamage on 1.13+, ItemStack#setDurability on older versions
- BlockDataService hard-referenced org.bukkit.block.TileState (1.14+), throwing NoClassDefFoundError on every block place/break/interact on 1.8 - guard the instanceof reflectively; pre-1.14 relies on the file-based BlockStorage
- cast to org.bukkit.inventory.meta.Damageable (1.13+) crashed Seismic Axe and similar items on 1.8 - reflective getDamage/setDamage on 1.13+, ItemStack durability on older versions
- refresh() built dough's RecipeSnapshot unconditionally; its instanceof Keyed threw NoClassDefFoundError on 1.8 and aborted the snapshot - guard construction on org.bukkit.Keyed presence; the getters already tolerate a null snapshot
- -PlocalAddons builds addons-src working copies as-is (skips git reset) for iterating local addon ports - run-headless.ps1 boots a version, captures the log, auto-stops once started - copyAddonJar survives a jar locked by a stale server; resolve addon gradlew by absolute path
…as no upload API)
…ports the real version (not 5.0.0-UNOFFICIAL)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support for Minecraft versions up to 1.21.11 and upgrades to Java 21.
Proposed changes
I modified the code to work with newer spigot versions, while still supporting any older versions.
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values