magneto: fail cleanly when out of memory - #157
Closed
ViezeVingertjes wants to merge 1 commit into
Closed
ViezeVingertjes wants to merge 1 commit into
ViezeVingertjes wants to merge 1 commit into
Conversation
magneto_current_calibration makes ~27 unchecked k_malloc calls (~1KB peak) from the 2KB system heap pool. Under heap pressure it wrote through NULL and hard-faulted mid mag calibration (#89). Check every allocation, unwind and return nonzero with BAinv untouched, and stop ignoring the Hessenberg_Form_Elementary return values. Callers log the failure and keep the previous calibration. Host-tested with fault injection at every allocation index: clean error return, nothing leaked, output never touched.
ViezeVingertjes
marked this pull request as ready for review
August 5, 2026 18:34
Member
|
almost nothing uses the system heap, and they also do not use heap at the same time; so this is not necessary |
Author
Which is true, but it's cumulative and it happens rather quickly <10 minutes, is quite invisible and only a reset fixes it. These are just fragments of my personal fork seperated, so might be surfacing more quickly in my version but its certainly in upstream, so wouldnt hurt imho. But if it isnt an issue (yet), feel free to close it, when it comes one its still in the history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
magneto_current_calibration makes ~27 unchecked k_malloc calls (~1KB peak) from the 2KB system heap pool. Under heap pressure it wrote through NULL and hard-faulted mid mag calibration (#89). Check every allocation, unwind and return nonzero with BAinv untouched, and stop ignoring the Hessenberg_Form_Elementary return values. Callers log the failure and keep the previous calibration.
Host-tested with fault injection at every allocation index: clean error return, nothing leaked, output never touched.