Skip to content

Use Ukrainian VAT abbreviation for Ukraine tax name#463

Open
afurm wants to merge 1 commit intoShopify:mainfrom
afurm:af/fix-ua-tax-name
Open

Use Ukrainian VAT abbreviation for Ukraine tax name#463
afurm wants to merge 1 commit intoShopify:mainfrom
afurm:af/fix-ua-tax-name

Conversation

@afurm
Copy link
Copy Markdown

@afurm afurm commented May 7, 2026

What are you trying to accomplish?

Correct the Ukraine region tax name from the Latin transliteration PDV to the Ukrainian Cyrillic abbreviation ПДВ. The State Tax Service of Ukraine uses ПДВ for податок на додану вартість, including on its VAT registration guidance: https://tax.gov.ua/baneryi/onlayn-navchannya/reestratsiya-ta-oblik-yuridichnih-osib-ta-samozaynyatih-fizichnih-osib/reestratsiya-platnikiv-pdv/987813.html

What approach did you choose and why?

Updated data/regions/UA.yml to use the native Ukrainian abbreviation and added a focused regression assertion in RegionTest so the value stays covered.

What should reviewers focus on?

Whether ПДВ is the expected user-facing tax name for Ukraine in this data file.

The impact of these changes

Consumers reading Worldwide.region(code: "UA").tax_name now receive the Ukrainian abbreviation used in official tax materials instead of a Latin transliteration.

Testing

  • RBENV_VERSION=3.4.7 bundle exec ruby -Itest test/worldwide/region_test.rb
  • RBENV_VERSION=3.4.7 bundle exec ruby -Itest test/worldwide/region_yml_consistency_test.rb

Checklist

  • I have added a CHANGELOG entry for this change (or determined that it is not needed)

@afurm afurm marked this pull request as ready for review May 7, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant