Use Ukrainian VAT abbreviation for Ukraine tax name#463
Open
afurm wants to merge 1 commit intoShopify:mainfrom
Open
Use Ukrainian VAT abbreviation for Ukraine tax name#463afurm wants to merge 1 commit intoShopify:mainfrom
afurm wants to merge 1 commit intoShopify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Correct the Ukraine region tax name from the Latin transliteration
PDVto the Ukrainian Cyrillic abbreviationПДВ. The State Tax Service of Ukraine usesПДВforподаток на додану вартість, including on its VAT registration guidance: https://tax.gov.ua/baneryi/onlayn-navchannya/reestratsiya-ta-oblik-yuridichnih-osib-ta-samozaynyatih-fizichnih-osib/reestratsiya-platnikiv-pdv/987813.htmlWhat approach did you choose and why?
Updated
data/regions/UA.ymlto use the native Ukrainian abbreviation and added a focused regression assertion inRegionTestso the value stays covered.What should reviewers focus on?
Whether
ПДВis the expected user-facing tax name for Ukraine in this data file.The impact of these changes
Consumers reading
Worldwide.region(code: "UA").tax_namenow receive the Ukrainian abbreviation used in official tax materials instead of a Latin transliteration.Testing
RBENV_VERSION=3.4.7 bundle exec ruby -Itest test/worldwide/region_test.rbRBENV_VERSION=3.4.7 bundle exec ruby -Itest test/worldwide/region_yml_consistency_test.rbChecklist