Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Today, BR's
splitAddress1regex only matches 2-component canonical input (<street>,<number>). When given 3-component input (<street>,<number>,<complement>— common in autofill payloads from Chrome, password managers, and PayPal), the regex bails to the fallback and returns the entire string instreetName.This adds an optional third capture group for line2 so 3-component inputs are parsed correctly. The change is in BR's region data only; no library code changes.
Backward compatibility: existing 2-component inputs continue to match the regex with no
line2field — confirmed via existing test cases (all unchanged). Addingline2to the result is additive — consumers readingstreetName/streetNumberare unaffected; consumers wantingline2can opt in.Note: this leaves
combined_address_formatuntouched.line2remains canonically inaddress2. The regex is for parsing flat natural-language strings (which mix all components); the canonical format is for structured serialization. The library already supports this asymmetry by design.What approach did you choose and why?
...
What should reviewers focus on?
...
The impact of these changes
...
Testing
...
Checklist