Conversation
st0012
commented
Apr 6, 2025
| const rbs::Comment &assertion) { | ||
| rbs_string_t rbsString = makeRBSString(assertion.string); | ||
| const rbs::RBSDeclaration &assertion) { | ||
| string signatureString = assertion.string(); |
Member
Author
There was a problem hiding this comment.
We need to hold the string value here to make sure it has the same lifecycle as this entire function.
| uint32_t continueIndex = index + line.size(); | ||
|
|
||
| // Look downwards (later lines) for continuation lines starting with "#|" | ||
| auto forwardIt = all_lines.begin() + 1 + distance(it, all_lines.rend()) - |
Member
Author
There was a problem hiding this comment.
To read consequent lines, I used another iterator to continue moving down.
This comment was marked as spam.
This comment was marked as spam.
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
multiline-sig-2
branch
from
faffc28 to
5859b33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I added the new
RBSDeclarationclass to one or multiple comments as in many context, especially type translation, we won't know which exact comment to pass down beforehand. WithRBSDeclaration::typeLocFromRange, we should be able to convert the rbs token range into a Sorbet location.With
RBSDeclaration, supporting multiline helpers, assertions, or attribute signatures will be easier too.Test plan
See included automated tests.