Make GSPO loss length-proportional#544
Open
jlamypoirier wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex GPT-5 note:
Summary
Rationale
PipelineRL DeepSpeed GSPO uses length-proportional sequence weighting when group_normalization=false: each segment contributes in proportion to its labeled-token count. Fast-LLM was still using mask / num_labels_in_seq as both the geometric-mean normalizer and the loss weight, making each document contribute uniformly regardless of length. This keeps num_labels_in_seq for the ratio/advantage means but uses the label mask as the loss/gradient weight.
Test