Add Abscissa class - #220
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
6ba4d18 to
1d2d3f5
Compare
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
1d2d3f5 to
5cdb04d
Compare
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
jamescrake-merani
left a comment
jamescrake-merani
left a comment
There was a problem hiding this comment.
I think this all looks good. Definitely better than the Spiderman film! I just had one small comment regarding tests, but if you think they're good then I'm approving this anyway so you can just merge.
|
|
||
|
|
||
| def test_1d(basic_metadata): | ||
| q = [1, 2, 3, 4, 5] |
There was a problem hiding this comment.
For these tests: do you think it would be worth introducing some more test data?
3 participants
This PR introduces the
Abscissaclass, which is able to determine the abscissa for given data types.This PR also has the benefit of reducing the need to look at the
_data_contentsof aSasMeasurement, as discussed in #207, in favour of looking at abscissae/ordinates. This improves the code we have to ensure a greater element of duck-typing.