Skip to content

Shadow pricing fix by updating the workplace segment field - #442

Merged
bhargavasana merged 1 commit into
mainfrom
shadow_pricing_fix
Aug 14, 2026
Merged

Shadow pricing fix by updating the workplace segment field #442
bhargavasana merged 1 commit into
mainfrom
shadow_pricing_fix

Conversation

@JiaXu1024

Copy link
Copy Markdown
Contributor

Close #434

Proposed changes

Add the following to src/asim/configs/resident/shadow_pricing.yaml:

SEGMENT_TO_NAME:
school: school_segment
workplace: occupation

Impact

See issue #434

Types of changes

What types of changes does your code introduce to ABM?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • Run model runs with (runid: 572) and without (runid: 570) the shadow pricing fix and compared the model outputs.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@JiaXu1024
JiaXu1024 requested a review from bhargavasana August 12, 2026 00:45
@JiaXu1024 JiaXu1024 self-assigned this Aug 12, 2026
@bhargavasana

Copy link
Copy Markdown
Collaborator

This should be sufficient for now so that workplace simulation-based matching produces acceptable results. There might be follow-up updates needed when we move to the next ActivitySim version based on ActivitySim/activitysim#1082 and ActivitySim/activitysim#1083.

@bhargavasana
bhargavasana merged commit 7e8988f into main Aug 14, 2026
@bhargavasana
bhargavasana deleted the shadow_pricing_fix branch August 14, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate simulation shadow-pricing workplace segmentation and test explicit SEGMENT_TO_NAME setting

2 participants