fix glam 0.33 breakage#609
Merged
Merged
Conversation
dd5bfdf to
f76580f
Compare
LegNeato
approved these changes
Jun 8, 2026
Collaborator
LegNeato
left a comment
There was a problem hiding this comment.
Agreed this is a good fix.
Can we put raw glam in cargo-deny w/ an override for so we can't use it directly w/o CI failing?
Contributor
|
Docs failed to build with these changes: https://github.com/Rust-GPU/rust-gpu/actions/runs/27157018177/job/80162386469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glam 0.33 introduced a feature for each type of vector to speed up compile times. This caused rust-gpu to break when used with glam 0.33, which is completely our fault, since we declare our dependency on glam to be forwards compatible even across breaking changes:
The simple fix is to just require glam 0.33, like the second commit does:
However, there are a few important libraries that still depend on an older glam version, like the most recent release of bevy_math still depending on
glam v0.30.*.Instead, I would like to propose that we have one feature for each glam version, and default to the most recent one:
And within
lib.rswe'll switch on the feature gate to select the glam version:Note that this does not support multiple glam versions simultaneously, but I don't think that matters. Maintaining this is cheap, so we can just maintain backwards compatible for whatever N versions that we can be bothered to.
Expect a crates alpha release soon after merging this.
close #602