FITB: Import local libraries - #1311
Merged
Merged
Conversation
Contributor
Author
Member
|
thanks @dbrianwalton |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RS component code defining FITB questions had the option to define additional libraries that would be loaded when the problem is injected into the surrounding HTML. As far as I know, this had not been used beyond the default loading of
BTMlibraries. PreTeXt did not yet have any way to define those libraries.When adding the support on the PreTeXt side, I realized that any JS files that were attempting to be loaded from the assets were in the wrong relative location, since
import()looks relative to the calling library, which in this case is the RS component itself. So that relative locations based on PreTeXt projects is preserved, this pull request adds the document context to create an absolute URL rather than remain in a relative URL that points the wrong location.