Skip to content

fix: downloadPublicImportFile doesn't use serverFetch with domain/IP validation checks - #41862

Merged
julio-rocketchat merged 1 commit into
release-8.4.6from
backport-8.4.6-41749
Aug 19, 2026
Merged

julio-rocketchat merged 1 commit into
release-8.4.6from
backport-8.4.6-41749

Conversation

@dionisio-bot

@dionisio-bot dionisio-bot Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #41749

Review in cubic

…validation checks (#41749)

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@dionisio-bot
dionisio-bot Bot requested review from a team as code owners August 19, 2026 09:36
@dionisio-bot dionisio-bot Bot added the backport Used to inform backported PR label Aug 19, 2026
@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 99d8ff6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot

dionisio-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov

codecov Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.4.6@458ac3f). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-8.4.6   #41862   +/-   ##
================================================
  Coverage                 ?   69.87%           
================================================
  Files                    ?     3313           
  Lines                    ?   121435           
  Branches                 ?    21744           
================================================
  Hits                     ?    84851           
  Misses                   ?    33258           
  Partials                 ?     3326           
Flag Coverage Δ
e2e 59.57% <ø> (?)
e2e-api 47.09% <ø> (?)
unit 70.48% <84.37%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-rocketchat
julio-rocketchat merged commit 8265bbc into release-8.4.6 Aug 19, 2026
80 of 82 checks passed
@julio-rocketchat
julio-rocketchat deleted the backport-8.4.6-41749 branch August 19, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Used to inform backported PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant