chore(deps): bump adm-zip#41476
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (4)
|
| Layer / File(s) | Summary |
|---|---|
Align adm-zip package versions package.json, apps/meteor/package.json, packages/apps/package.json |
The root Yarn resolution and both package dependencies now reference adm-zip version 0.6.0; the Meteor package no longer declares @types/adm-zip. |
Estimated code review effort: 1 (Trivial) | ~2 minutes
Suggested labels: type: chore
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly and concisely describes the main change: bumping the adm-zip dependency. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/apps/package.json (1)
39-39: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove redundant
@types/adm-zipdeclarations after verification.
adm-zip@0.6.0includes bundled TypeScript declarations. Confirm they cover both consumers, then remove the parallel@types/adm-zipdependencies to avoid maintaining duplicate type sources. (npmjs.com)
packages/apps/package.json#L39-L39: verifypackages/apps/src/server/compiler/AppPackageParser.ts, then remove@types/adm-zipat Line 52 if covered.apps/meteor/package.json#L170-L170: verifyapps/meteor/server/lib/import/csv/CsvImporter.ts, then remove@types/adm-zipat Line 347 if covered.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/apps/package.json` at line 39, Verify that the bundled adm-zip declarations cover packages/apps/src/server/compiler/AppPackageParser.ts, then remove the `@types/adm-zip` dependency from packages/apps/package.json at lines 39-39 and 52. Also verify coverage for apps/meteor/server/lib/import/csv/CsvImporter.ts, then remove its `@types/adm-zip` dependency from apps/meteor/package.json at lines 170-170 and 347.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/apps/package.json`:
- Line 39: Verify that the bundled adm-zip declarations cover
packages/apps/src/server/compiler/AppPackageParser.ts, then remove the
`@types/adm-zip` dependency from packages/apps/package.json at lines 39-39 and 52.
Also verify coverage for apps/meteor/server/lib/import/csv/CsvImporter.ts, then
remove its `@types/adm-zip` dependency from apps/meteor/package.json at lines
170-170 and 347.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8a8b3b4e-3d60-4737-88da-959434f085fc
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
apps/meteor/package.jsonpackage.jsonpackages/apps/package.json
📜 Review details
⏰ Context from checks skipped due to timeout. (5)
- GitHub Check: 📦 Build Packages
- GitHub Check: cubic · AI code reviewer
- GitHub Check: CodeQL-Build
- GitHub Check: Hacktron Security Check
- GitHub Check: CodeQL-Build
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2026-06-16T14:13:34.463Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 40974
File: packages/web-ui-registration/package.json:31-31
Timestamp: 2026-06-16T14:13:34.463Z
Learning: In Rocket.Chat’s monorepo, when reviewing a dependency entry and flagging that a specific version “does not exist” (e.g., in package.json), first verify the exact package/version directly against the npm registry (use URLs like https://registry.npmjs.org/<package>/<version> or https://www.npmjs.com/package/<package>/v/<version>). Do not rely on web search results for this check, since they may be stale or cached and may not reflect the latest published versions.
Applied to files:
packages/apps/package.json
📚 Learning: 2026-06-16T14:13:49.795Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 40974
File: packages/web-ui-registration/package.json:26-26
Timestamp: 2026-06-16T14:13:49.795Z
Learning: During code reviews that check whether a dependency version exists in package.json (especially for Rocket.Chat’s rocket.chat/fuselage and related rocket.chat/fuselage-* packages), don’t rely on web search results. Instead, verify the version directly against the npm registry (e.g., via the npm registry API or the canonical package URL https://www.npmjs.com/package/<package>/v/<version>) before deciding that a version bump is invalid. If the version is present in the npm registry, do not flag it as invalid.
Applied to files:
packages/apps/package.json
📚 Learning: 2026-06-16T14:13:59.986Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 40974
File: packages/ui-video-conf/package.json:25-25
Timestamp: 2026-06-16T14:13:59.986Z
Learning: In the Rocket.Chat monorepo, when reviewing a dependency version bump for rocket.chat/fuselage in a package.json, do not flag the new version constraint as “non-existent” or invalid unless you verify the published versions directly from the npm registry (https://www.npmjs.com/package/rocket.chat/fuselage). Don’t rely on search/web results for available versions since they can be stale.
Applied to files:
packages/apps/package.json
🔇 Additional comments (1)
package.json (1)
41-41: LGTM!
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/apps/package.json">
<violation number="1" location="packages/apps/package.json:39">
P2: `adm-zip` 0.6.0 ships its own TypeScript type declarations, making the separate `@types/adm-zip@^0.5.7` devDependency redundant and potentially conflicting. Consider removing `@types/adm-zip` from devDependencies since it targets the 0.5.x API and is no longer needed.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41476 +/- ##
===========================================
- Coverage 68.63% 68.58% -0.06%
===========================================
Files 4134 4134
Lines 160805 160801 -4
Branches 29304 29259 -45
===========================================
- Hits 110376 110280 -96
- Misses 45321 45420 +99
+ Partials 5108 5101 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
julio-rocketchat
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
3 participants
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit