Expose internal_validate() on the C++ Roaring and Roaring64Map wrappers - #890
Merged
lemire merged 1 commit intoSep 24, 2026
Merged
Conversation
readSafe() does not validate container structure, and the C++ wrappers did not surface roaring_bitmap_internal_validate. Expose it on both.
Member
|
Running tests. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readSafe()only guarantees the input buffer is not read out of bounds, it still accepts structurally invalid containers.For example, a run container declaring
n_runs == 0deserializes into a container with a NULLrunspointer:readSafe()succeeds, but the first set operation dereferences thatNULLpointer and crashes.The C API exposes
roaring_bitmap_internal_validatefor untrusted input, but the C++ wrappers did not surface it, andRoaring64Map's inner bitmaps are private, so callers could not validate them without re-parsing.