Skip to content

Windows: improve dependency lookup when loading module library.#179

Open
bruvzg wants to merge 1 commit into
RenderKit:masterfrom
bruvzg:win_dep_lib_lookup_path
Open

Windows: improve dependency lookup when loading module library.#179
bruvzg wants to merge 1 commit into
RenderKit:masterfrom
bruvzg:win_dep_lib_lookup_path

Conversation

@bruvzg

@bruvzg bruvzg commented Oct 14, 2023

Copy link
Copy Markdown

Fixes loading of the module library dependencies when OIDN main library is dynamically loaded at runtime, and libraries are not in the executable directory.

e.g., when app dynamically load OpenImageDenoise.dll at runtime, using absolute path, ModuleLoader attempts to load OpenImageDenoise_device_cpu.dll module, but it fails since tbb12.dll is not in the library search path. This change temporary adds the module library directory to the search path to ensure dependencies are loaded correctly.

@Calinou

Calinou commented Jun 18, 2024

Copy link
Copy Markdown

Bump 🙂 Any interest in reviewing this? This would make it possible for Godot to use OIDN as a library, as opposed to calling its oidnDenoise CLI (which doesn't have a stable interface).

@atafra

atafra commented Jun 28, 2024

Copy link
Copy Markdown
Collaborator

Sorry, there is interest but so far we had other priorities. We need to look into this carefully because it might have some security implications as well.

@kraszkow

kraszkow commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

@bruvzg - Could you provide specific details about the problem you're addressing? It would be helpful if you could show the exact location of the DLLs mentioned in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants