Repository navigation
Conversation
Merged
In 2.1 get_quick_bar_slot returns a table, {type, filter} or {type,
item}, not an item prototype, so .name on it was nil: auto stash failed
with "table index is nil" for any player with a quick bar slot set, and
saving quick bars saved empty bars. Both now take the name from the
slot's filter or item.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2.1 removed LuaEntity.neighbours. Underground belts now have underground_belt_neighbour and pipes-to-ground fluidbox_neighbours, which the Citadel, Fault Lines and Rivers tests use through connected(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since 2.1 a flow added with on_flow shows up in the statistics two ticks later, so the tests read the counts before it had landed: the first failed on every Danger Ores map, and "other items do not count" passed without checking anything. Each test now waits for its own flow first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI now tests the latest stable 2.1 release, and AGENTS.md says the scenario targets 2.1 and lists the 2.0 API it removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lex
force-pushed
the
event-registry-debug
branch
from
October 25, 2026 11:11
8c469c8 to
88575cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1654 (Update to Factorio 2.1): until that merges this diff includes its commits too. The change for review is one commit: compare factorio-2.1...event-registry-debug.
RedRafe's commit from #1569, cherry-picked (it keeps his authorship). Under
_DEBUG,utils/event_corekeeps a count of the handlers registered per event (by name, e.g.on_player_created, pluson_init,on_loadandon_configuration_changed) and writes it toscript-output/event_handler_registry.jsoneach time one is added, to see which events a scenario listens to. Without_DEBUGnothing changes.It doesn't depend on 2.1, but
developno longer runs on a 2.1 install, so it's stacked to be tested there. On a local 2.1.23 thedevelop,crashsiteanddiggytemplates pass (58, 90 and 71 passed, 0 failed);luacheck .: 0 warnings / 0 errors.🤖 Generated with Claude Code