Repository navigation
crash-site: add rate display for outpost crafters - #1649
Open
misterburgers wants to merge 2 commits into
Open
misterburgers wants to merge 2 commits into
misterburgers wants to merge 2 commits into
Conversation
misterburgers
force-pushed
the
crafter-rate-display
branch
from
October 24, 2026 17:55
8f2002f to
5202c0b
Compare
- Improves logic for market upgrade to be more consistently accurate
misterburgers
force-pushed
the
crafter-rate-display
branch
2 times, most recently
from
October 24, 2026 20:20
dfd567f to
dcf80b7
Compare
misterburgers
force-pushed
the
crafter-rate-display
branch
from
October 24, 2026 20:21
dcf80b7 to
6ef4bff
Compare
grilledham
reviewed
Oct 24, 2026
| local prototype = Retailer.get_items(outpost_id)['upgrade'] | ||
|
|
||
| local outpost_magic_crafters = outpost_data.magic_crafters | ||
| if #outpost_magic_crafters == 0 then |
Collaborator
There was a problem hiding this comment.
Do we also need to consider magic_fluid_crafters here too?
grilledham
reviewed
Oct 24, 2026
Comment on lines
+2056
to
+2060
| if selected.name == 'assembling-machine-2' or | ||
| selected.name == 'assembling-machine-3' or | ||
| selected.name == 'chemical-plant' or | ||
| selected.name == 'electric-furnace' or | ||
| selected.name == 'centrifuge' then |
Collaborator
There was a problem hiding this comment.
MAybe we should use types here instead of names, to make this compatible with mods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a text field to magic crafters that gets displayed when they are moused over. This is only displayed in map mode, same as the market text. Works for all crafters. This change is best shown with some screenshots, so here's some examples. For each of these, I've run my mouse over all the crafters so they will show their text.
Center base

Minor base

Major base

One output refineries

Three output refineries

This change also includes some updates to the logic for the market upgrade and updates it more consistently.
It also changes text so that it displays even when an outpost is not captured.