docs: fix \code{} tag in melt.Rd, add factor to nafill.Rd @param x#7778
Open
LeonidasZhak wants to merge 2 commits into
Open
docs: fix \code{} tag in melt.Rd, add factor to nafill.Rd @param x#7778LeonidasZhak wants to merge 2 commits into
LeonidasZhak wants to merge 2 commits into
Conversation
Add a grouped rolling mean example showing frolladapt + frollmean with by= for panel data. This is the data.table equivalent of Stata's rangestat (mean) ..., int(date -2 0) by(firm) for time-aware rolling windows within groups respecting irregular date gaps.
- melt.data.table.Rd:59 — \code{numeric > integer > logical} had broken
\code{} tag spanning two lines; each type now wrapped individually
- nafill.Rd:17 — @param x listed 'logical, numeric or character' but
Details section and examples confirm factor is also supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small documentation fixes:
1. melt.data.table.Rd line 59 — broken \code{} tag
The type coercion hierarchy was rendered with inconsistent formatting:
The \code{} tag spanned across two lines, putting the
>signs between numeric/integer/logical inside monospace code while leaving list/character comparisons as plain text. Fixed to wrap each type individually:2. nafill.Rd line 17 — @param x missing factor
The
@param xdescription listed supported types as "logical, numeric or character" but the Details section (line 24) and examples (lines 40-43) confirm factor is also supported. Updated to match.Validation
tools::checkRd('man/melt.data.table.Rd')— passestools::checkRd('man/nafill.Rd')— passesFiles changed