Do not rename data.table.dll to data_table.dll#7777
Open
aitap wants to merge 2 commits into
Open
Conversation
Since R-2.15, R automatically replaces dots with understores in R_init_<DLL name>(...), so renaming is no longer necessary. This also has the side effect of working around the behaviour change from R r90101 and producing correct source tarballs on Windows again: R CMD build cleans up data.table.dll, but misses data_table.dll.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7777 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 87 87
Lines 17128 17128
=======================================
Hits 16932 16932
Misses 196 196 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated via commit 4a242e5 Download link for the artifact containing the test results: ↓ atime-results.zip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to old versions of WRE, R automatically replaces dots with understores in
R_init_<DLL name>()since R-2.15, so renaming is no longer necessary. This also has the side effect of working around the behaviour change from R r90101 and producing correct source tarballs on Windows again: for now, after temporarily installing the package,R CMD buildcleans updata.table.dll, but missesdata_table.dll.