Fix for launch_latency. - #2564
Conversation
There was a problem hiding this comment.
Does this need to be unblocked immediately?
IMHO we should keep that info for debugging purposes.
Ideas that come to mind:
- redirect into another "error" log file (need to make sure this cannot become stale)
- teach the CI extraction to ignore these warnings
IMHO we should pipe it to another file. If we make the extract script to ignore the logs, we're just waiting for rocprofiler to change nad our tests to break again. If we hit an error return code, the test should fail and output the log. Otherwise just overwrite it the next run / add it to |
Lynd98
left a comment
Lynd98
left a comment
There was a problem hiding this comment.
Changed /dev/null to ./rocprofv3.log. Because it is a *.log file, it is removed by "make clean".
mhalk
left a comment
mhalk
left a comment
There was a problem hiding this comment.
Looks good, thanks Lynd!
Please consider adding / trying my suggestion so we get output in case of an error.
Once that's taken care of, I think this is good to go :)
| CC = $(OMP_BIN) $(VERBOSE) | ||
| RUNENV = ulimit -s unlimited; | ||
| RUNCMD = $(AOMPHIP)/bin/rocprofv3 --output-format csv --kernel-trace --stats -- ./$(TESTNAME) && python3 printLatency.py | ||
| RUNCMD = $(AOMPHIP)/bin/rocprofv3 --output-format csv --kernel-trace --stats -- ./$(TESTNAME) 2> ./rocprofv3.log && python3 printLatency.py |
There was a problem hiding this comment.
Idea to accommodate JP's suggestion (please check): add sth. like || cat ./rocprofv3.log
Unsure if we want sth. "more sophisticated" like ReturnCode printing.
Style: I'd also try if we can improve readability by moving this into a new line like this:
(really just an idea, I did not test this)
| RUNCMD = $(AOMPHIP)/bin/rocprofv3 --output-format csv --kernel-trace --stats -- ./$(TESTNAME) 2> ./rocprofv3.log && python3 printLatency.py | |
| RUNCMD = $(AOMPHIP)/bin/rocprofv3 --output-format csv --kernel-trace --stats -- ./$(TESTNAME) 2> ./rocprofv3.log | |
| RUNCMD += && python3 printLatency.py || cat ./rocprofv3.log |
3 participants
Motivation
In CI, the launch_latency report has error and warning messages represented as timings; needed to delete these messages.
Technical Details
Changed the launch_latency Makefile to send error and warning messages to /dev/null.
Test Plan
Reran launch_latency, checked for error and warning mesages.
Test Result
None