gdb/testsuite/rocm/runtime-core: ensure all or no test run#177
Merged
lancesix merged 1 commit intoJul 17, 2026
Merged
Conversation
lumachad
reviewed
Jun 18, 2026
lancesix
force-pushed
the
users/lancesix/ensure-all-runtime-core-test-run-or-none
branch
from
June 18, 2026 11:18
e02b7f1 to
04093d6
Compare
Collaborator
|
With the fix I now see the following: Probably need an extra fix to rocr-runtime? |
lumachad
approved these changes
Jun 18, 2026
lumachad
left a comment
lumachad
left a comment
Collaborator
There was a problem hiding this comment.
The change itself is OK for me.
Collaborator
Author
would you have the gdb.log with those 2 untested entries I could look at? |
palves
reviewed
Jun 18, 2026
When working on coredump related issue, it was noticed that some runtime changes could work in some conditions but fail in others. The gdb.rocm/runtime-core.exp testcase was not really complaining about that, it would validate the core dumps when produced and skip the test if the core was absent. It is expected that if the system configuration is not adequate, none of the runtime-core cases would run, but if at least one can run, it means all must also run. This test ensures that we run either all or none of the testcase, and issue a FAIL if this property is not satisfied. Change-Id: Ic79b958a0991b21dc1dfeb6bb13b3f292c53261f
lancesix
force-pushed
the
users/lancesix/ensure-all-runtime-core-test-run-or-none
branch
from
June 18, 2026 22:15
04093d6 to
be26f87
Compare
Collaborator
Author
|
Applied suggestions to comments. |
palves
approved these changes
Jul 3, 2026
Contributor
|
@lancesix, can this be merged? |
Collaborator
|
We need to re-trigger CI and see if the tests pass. The previous run skipped rocgdb testing. |
Collaborator
Author
I think so. If I emember correctly, it was help as it could start to issues fails due to some other bug, but should be ok now (otherwise, CI will eventually let me know). |
Collaborator
Actually, this is a corefile test. Se we should validate it locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on coredump related issue, it was noticed that some runtime changes could work in some conditions but fail in others. The gdb.rocm/runtime-core.exp testcase was not really complaining about that, it would validate the core dumps when produced and skip the test if the core was absent.
It is expected that if the system configuration is not adequate, none of the runtime-core cases would run, but if at least one can run, it means all must also run.
This test ensures that we run either all or none of the testcase, and issue a FAIL if this property is not satisfied.
Change-Id: Ic79b958a0991b21dc1dfeb6bb13b3f292c53261f