perf: Leverage collect_all for eager collection validation & filtering#363
Open
Oliver Borchert (borchero) wants to merge 3 commits into
Open
perf: Leverage collect_all for eager collection validation & filtering#363Oliver Borchert (borchero) wants to merge 3 commits into
collect_all for eager collection validation & filtering#363Oliver Borchert (borchero) wants to merge 3 commits into
Conversation
Oliver Borchert (borchero)
requested review from
Andreas Albert (AndreasAlbertQC) and
Daniel Elsner (delsner)
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## semi-join #363 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 56 56
Lines 3475 3481 +6
===========================================
+ Hits 3475 3481 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using
collect_allallows for considerable performance gains, esp. if the number of filters and/or members is large (and a sufficient number of CPU cores is available).On my machine, this yields speedups of ~25-30% on our benchmark data.