Repository navigation
Add Orchard V3 and Ironwood V3 fixed digest tests - #266
Merged
Merged
Conversation
ConstanceBeguier
force-pushed
the
add_ironwood_v3_fixed_tests
branch
from
September 10, 2026 07:25
d57e903 to
035f621
Compare
ConstanceBeguier
changed the base branch from
remove_orchard_primitives
to
zsa1
September 10, 2026 07:25
Some tests have been renamed.
ConstanceBeguier
force-pushed
the
add_ironwood_v3_fixed_tests
branch
from
September 10, 2026 07:44
035f621 to
2558802
Compare
ConstanceBeguier
changed the title
PaulLaux
approved these changes
Sep 10, 2026
PaulLaux
left a comment
PaulLaux
left a comment
Collaborator
There was a problem hiding this comment.
Approved with minor comments
| /// Verifies that the hash for an Orchard V3 bundle matches a fixed reference value. | ||
| /// | ||
| /// Orchard V3 mandates the cross-address restriction, so this bundle is built from change | ||
| /// outputs; see [`generate_change_only_bundle`]. |
Collaborator
There was a problem hiding this comment.
generate_change_only_bundle_for_orchard_v3?
| /// reference value. | ||
| /// | ||
| /// Orchard V3 mandates the cross-address restriction, so this bundle is built from change | ||
| /// outputs; see [`generate_change_only_bundle`]. |
Collaborator
There was a problem hiding this comment.
generate_change_only_bundle_for_orchard_v3?
| /// cross-address transfers. | ||
| /// | ||
| /// Each change output pairs with a spend the wallet controls (`dummy_sk: None`), so unlike | ||
| /// [`generate_auth_bundle`], whose spends are all padding dummies that `finalize` signs |
Collaborator
There was a problem hiding this comment.
finalize should be prepare
|
|
||
| builder | ||
| .add_change_output( | ||
| fvk.clone(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated PR #240 to obtain the fixed digest values for Orchard V3 and Ironwood V3.