Fix visualizer server startup failures - #1225
Merged
rickwierenga merged 2 commits intoAug 28, 2026
Merged
Conversation
Member
|
thanks for the pr! please green the ci |
Contributor
Author
|
Fixed the Python 3.9 mypy failure by treating server.sockets as an iterable rather than indexing it. The focused type check now passes, along with all 26 visualizer tests, Ruff, and format checks. |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
EADDRINUSE, with a 100-port limitsetup()0so tests can request OS-assigned portspytest-timeoutdependencyTests
python -m pytest pylabrobot/visualizer/visualizer_tests.py -q(26 passed)python -m ruff check pylabrobot/visualizer/visualizer.py pylabrobot/visualizer/visualizer_tests.pypython -m ruff format --check pylabrobot/visualizer/visualizer.py pylabrobot/visualizer/visualizer_tests.pypython -m mypy pylabrobot/visualizer/visualizer.pyResolves #1224