Stdlib: mb_ereg_replace/mb_decode_mimeheader(null) TypeError under strict_types (#30311) - #30357
Merged
Merged
Conversation
…rict_types (#30311) Use trimFamilyStringArgForFrame (caller strict_types) so null string args match Zend TypeError instead of soft-coercing; keep non-strict Deprecated+coerce. JIT/AOT compile-time null rejects added. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declare(strict_types=1),mb_ereg_replace(null, …)andmb_decode_mimeheader(null)now raise Zend-matchingTypeErrorinstead of soft-coercing.VmString::trimFamilyStringArgForFrame(strict TypeError; non-strict Deprecated+coerce retained).JitInternalStrictArg::rejectNullString.ext/mbstring/mbstring.stub.php,php_mbregex.c,mbstring.c.Closes #30311
Test plan
test/repro/issue_30311_mb_ereg_replace_decode_mimeheader_null_strict.php) — TypeError messages match'bcb'/'')vendor/bin/phpunit test/compliance/MbEregReplaceDecodeMimeheaderNullStrictVMTest.php— OKvendor/bin/phpunit test/compliance/MbEregReplaceDecodeMimeheaderNullStrictJITTest.php— OKvendor/bin/phpunit --filter 'mb_ereg_replace_decode_mimeheader_null_strict|mb_decode_mimeheader_null_strict' test/aot/AotTest.php— OK (2 tests)Pre-work gates (master)
user_release_ready: no(stale DOM helper-runtime prelink — unrelated)Made with Cursor