Stdlib: DOMDocument::saveHTML() emit xmlns nsDef like Zend (#30350) - #30351
Merged
Conversation
serializeHtmlElement used Attr-map-only dumping, so loadXML/createElementNS namespace declarations vanished under saveHTML while saveXML stayed correct. Reuse serializeElementAttributes (htmlNodeDump nsDef) for the HTML path. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMDocument::saveHTML()/saveHTML($node)droppedxmlns/xmlns:*that Zend/libxmlhtmlNodeDumpemits afterloadXMLorcreateElementNS(saveXMLwas already correct).serializeHtmlElement()used Attr-map-onlyserializeAttributes(); switched to sharedserializeElementAttributes()(nsDef + Attr map, same as saveXML / Regression: DOMDocument::createElementNS() saveXML drops xmlns declarations (re-#14314/#15381, ext/dom/node.c) #19397).ext/dom/VmDom.php.Test plan
php bin/vm.php test/repro/issue_30350_dom_savehtml_xmlns.php(andbin/jit.php) — all match Zendtest/compliance/cases/dom/dom_savehtml_xmlns_nsdef.phpt+ reproCloses #30350
Made with Cursor