Skip to content

Sample chapter: update output from 'make sample-chapter-representations' - #3055

Closed
Alex-Jordan wants to merge 1 commit into
PreTeXtBook:masterfrom
Alex-Jordan:sample-chapter-catchup
Closed

Sample chapter: update output from 'make sample-chapter-representations'#3055
Alex-Jordan wants to merge 1 commit into
PreTeXtBook:masterfrom
Alex-Jordan:sample-chapter-catchup

Conversation

@Alex-Jordan

Copy link
Copy Markdown
Contributor

This is simply the result of navigating to the examples/webwork/ folder and running make sample-chapter-representations. I'm not sure what led to this, but somewhere some changes were made to XSL files or to the pretext python script, and the output from make sample-chapter-representations was not kept up. So now as I work on things like #3053, these changes show up in the diff even though they have nothing to do with that work.

I also get changes in the generated images in sample-chapter/my-generated/webwork/images/, but I assume those are due to different LaTeX versions making those images, different versions of the tools used to convert PDF to other image files, metadata in the files, etc. I'm OK with just ignoring all that.

@rbeezer

rbeezer commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

We are now using ptx as a prefix/identifier fot LaTeX macrtos, like a crude namespacing technique. So I had to adjust an @xml:id for a problem if I recall right. (And failed to update the generated stuff.)

@rbeezer

rbeezer commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

for LaTeX macros

Moving too fast - also HTML id attributes for specific parts of the UI.

@rbeezer

rbeezer commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

c51bcb9 was the change that caused this

@rbeezer

rbeezer commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Merged. Apologies for the mess. I added in the image files, those changes belong as well, as part of a complete update.

Thanks for sounding the alarm on this one.

@rbeezer rbeezer closed this Jul 21, 2026
@Alex-Jordan

Copy link
Copy Markdown
Contributor Author

I missed something here. The repo has the file examples/webwork/sample-chapter/my-generated/webwork/pg/Integrating_WeBWorK_into_Textbooks/2-Technical_Examples/2_3-Stress_Tests/2_3_1-PTX_problem_source_with_servergenerated_images.pg, which this update should have updated to examples/webwork/sample-chapter/my-generated/webwork/pg/Integrating_WeBWorK_into_Textbooks/2-Technical_Examples/2_3-Stress_Tests/2_3_1-PreTeXt_problem_source_with_servergenerated_images.pg.

Instead, I added the new file without deleting the old one. What's preferred to remove it? I could put it on a standalone commit in an upcoming PR about removing unused junk now that we are beyond PG 2.18?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants