Skip to content

style: Clean up AI approval screen#2120

Open
Twixes wants to merge 1 commit intomainfrom
clean-up-ai-approval
Open

style: Clean up AI approval screen#2120
Twixes wants to merge 1 commit intomainfrom
clean-up-ai-approval

Conversation

@Twixes
Copy link
Copy Markdown
Member

@Twixes Twixes commented May 10, 2026

Problem

The org AI approval screen is friction-heavy due to taking the away into PostHog Cloud, but it's also been breaking a few UI rules, making for a less successful user experience:

Screenshot 2026-05-10 at 16 47 03@2x
  1. Disclose information progressively - with a single unformatted paragraph of information, it's hard to say as a user what all this commotion is about
  2. Thoughtful line breaks are part of layout – here, the line breaks appear random, despite this part of the UI being static width
  3. PostHog-specific: Writing should feel PostHoggy, i.e. professional and clean, but without taking itself too seriously, maybe especially so when talking about genuinely important topics like privacy agreements - overall this is fairly light, but then the legal note is unusually dry

Changes

Improved version:

  1. The most important fact explaining why you're seeing this is on its first line, with the organization in bold
  2. Line breaks are intentional to create a smooth flow of reading
  3. The legal note gets a heading so that most users know to simply skip it, and its style is subtly more PostHoggy without any change in meaning
Screenshot 2026-05-10 at 16 41 20@2x

@Twixes Twixes requested review from charlesvien and joshsny May 10, 2026 15:48
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 10, 2026

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/code/src/renderer/features/ai-approval/components/AiApprovalScreen.tsx:119-121
**Block element inside `<p>` — invalid HTML**

In Radix UI Themes, `Callout.Text` renders as a `<p>` element. Placing an `<h4>` (a block-level element) inside it produces invalid HTML; browsers will implicitly close the `<p>` before the `<h4>`, which can break the Callout layout unexpectedly. Consider using a `<span>` styled as bold/large instead, or wrapping the whole callout body in a `<div>` via the `asChild` prop or by splitting the content into separate elements outside `Callout.Text`.

### Issue 2 of 2
apps/code/src/renderer/features/ai-approval/components/AiApprovalScreen.tsx:122
The word "yet" turns this from a legal disclaimer into an implicit commitment that PostHog Code *will* become HIPAA-compliant in the future. The original phrasing made no such promise. This phrasing should be cleared with legal/compliance before shipping.

```suggestion
                    PostHog Code isn't HIPAA-compliant and is not
```

Reviews (1): Last reviewed commit: "style: Clean up AI approval screen" | Re-trigger Greptile

@Twixes Twixes requested review from hector-r-759 and k11kirky May 10, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant