Repository navigation
fix monotonic latency errors on MacOS - #1172
Merged
Merged
Conversation
RossBencina
reviewed
Aug 21, 2026
| PaSampleFormat hostInputSampleFormat, hostOutputSampleFormat; | ||
| UInt32 fixedInputLatency = 0; | ||
| UInt32 fixedOutputLatency = 0; | ||
| const double kLatencyEpsilon = 1e-10; /* Rounding error in frames. */ |
Collaborator
There was a problem hiding this comment.
Is the epsilon rounding required to pass the test? Is there any rationale behind 1e-10?
Collaborator
Author
There was a problem hiding this comment.
Most of the tests pass with just the ceil() call. But there was one failure that needed this epsilon fix.
The reportedLatency was low by 1e-19.
So 1e-10 seems much smaller than the human scale and much larger than the scale of the rounding errors.
RossBencina
reviewed
Aug 28, 2026
RossBencina
reviewed
Aug 28, 2026
philburk
force-pushed
the
fix_latency_mac_1171
branch
from
September 3, 2026 22:15
cdb7603 to
8dfa796
Compare
RossBencina
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rounding errors were causing the new paqa_latency_monotonic.c test to fail.
Fixes #1171