Bring back the proper themed icon - #78
Conversation
The icon redesign pointed the monochrome layer at the color foreground webp, which launchers tint into a shapeless blob. Point it back at the vector silhouette — the redesign only changed colors, so the shape still matches. Fixes #54
|
| Filename | Overview |
|---|---|
| app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml | Redirects the regular launcher’s monochrome layer to an existing vector drawable; required validation results remain undocumented. |
| app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml | Makes the equivalent monochrome-layer correction for the round launcher icon. |
Prompt To Fix All With AI
### Issue 1
app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml:5
**Document required validation results**
The PR description omits the required `:app:compileDebugKotlin`, `:app:lintDebug`, and `:app:testDebugUnitTest` results, preventing reviewers from confirming that the changed launcher resources pass the repository's prescribed checks.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Bring back the proper themed icon" | Re-trigger Greptile
| <background android:drawable="@mipmap/ic_launcher_background"/> | ||
| <foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
| <monochrome android:drawable="@mipmap/ic_launcher_foreground"/> | ||
| <monochrome android:drawable="@drawable/new_monochrome"/> |
There was a problem hiding this comment.
Document required validation results
The PR description omits the required :app:compileDebugKotlin, :app:lintDebug, and :app:testDebugUnitTest results, preventing reviewers from confirming that the changed launcher resources pass the repository's prescribed checks.
Context Used: CONTRIBUTING.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
Line: 5
Comment:
**Document required validation results**
The PR description omits the required `:app:compileDebugKotlin`, `:app:lintDebug`, and `:app:testDebugUnitTest` results, preventing reviewers from confirming that the changed launcher resources pass the repository's prescribed checks.
**Context Used:** CONTRIBUTING.md ([source](https://github.com/pixelplayerhq/pixelplayeross/blob/main/CONTRIBUTING.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
The icon redesign (cd8be40) pointed the monochrome layer at the color foreground webp, which launchers flat-tint into the blob from #54. This points it back at the existing vector silhouette — the redesign only changed the logo's colors, not its shape, so the old vector still matches.
Worth a quick look on a device with themed icons on before merging. Fixes #54.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.