Skip to content

Bring back the proper themed icon - #78

Merged
lostf1sh merged 1 commit into
mainfrom
fix-themed-icon
Aug 7, 2026
Merged

Bring back the proper themed icon#78
lostf1sh merged 1 commit into
mainfrom
fix-themed-icon

Conversation

@lostf1sh

@lostf1sh lostf1sh commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

The icon redesign (cd8be40) pointed the monochrome layer at the color foreground webp, which launchers flat-tint into the blob from #54. This points it back at the existing vector silhouette — the redesign only changed the logo's colors, not its shape, so the old vector still matches.

Worth a quick look on a device with themed icons on before merging. Fixes #54.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

The icon redesign pointed the monochrome layer at the color foreground
webp, which launchers tint into a shapeless blob. Point it back at the
vector silhouette — the redesign only changed colors, so the shape
still matches.

Fixes #54
@lostf1sh
lostf1sh merged commit 4c395aa into main Aug 7, 2026
5 checks passed
@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown

Greptile Summary

The PR restores the adaptive launcher icon’s monochrome layer by pointing both regular and round icon definitions to the existing vector silhouette.

  • Updates the regular adaptive icon’s monochrome drawable.
  • Applies the same change to the round adaptive icon.
  • Required build, lint, and unit-test results are not included in the PR description.

Confidence Score: 4/5

The resource change appears safe to merge once the repository-required build, lint, and unit-test results are documented.

Both launcher definitions reference an existing vector drawable, leaving only the non-blocking omission of required validation results.

Files Needing Attention: app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml, app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml

Important Files Changed

Filename Overview
app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml Redirects the regular launcher’s monochrome layer to an existing vector drawable; required validation results remain undocumented.
app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml Makes the equivalent monochrome-layer correction for the round launcher icon.

Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
### Issue 1
app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml:5
**Document required validation results**

The PR description omits the required `:app:compileDebugKotlin`, `:app:lintDebug`, and `:app:testDebugUnitTest` results, preventing reviewers from confirming that the changed launcher resources pass the repository's prescribed checks.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Bring back the proper themed icon" | Re-trigger Greptile

<background android:drawable="@mipmap/ic_launcher_background"/>
<foreground android:drawable="@mipmap/ic_launcher_foreground"/>
<monochrome android:drawable="@mipmap/ic_launcher_foreground"/>
<monochrome android:drawable="@drawable/new_monochrome"/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Document required validation results

The PR description omits the required :app:compileDebugKotlin, :app:lintDebug, and :app:testDebugUnitTest results, preventing reviewers from confirming that the changed launcher resources pass the repository's prescribed checks.

Context Used: CONTRIBUTING.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml
Line: 5

Comment:
**Document required validation results**

The PR description omits the required `:app:compileDebugKotlin`, `:app:lintDebug`, and `:app:testDebugUnitTest` results, preventing reviewers from confirming that the changed launcher resources pass the repository's prescribed checks.

**Context Used:** CONTRIBUTING.md ([source](https://github.com/pixelplayerhq/pixelplayeross/blob/main/CONTRIBUTING.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

@lostf1sh
lostf1sh deleted the fix-themed-icon branch August 7, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: make themed icon look coherent

1 participant