Skip to content

Make camera mismatch warning consistent with other UI warnings - #2596

Merged
samfreund merged 1 commit into
PhotonVision:mainfrom
spacey-sooty:v-banner-v-alert
Sep 1, 2026
Merged

Make camera mismatch warning consistent with other UI warnings#2596
samfreund merged 1 commit into
PhotonVision:mainfrom
spacey-sooty:v-banner-v-alert

Conversation

@spacey-sooty

Copy link
Copy Markdown
Member

Description

What changed?

Changed to v-alert instead of v-banner for the camera mismatch banner

Why?

This makes it more consistent with all the other UI warnings

Testing

  • I have tested this change locally
  • Test evidence (screenshots, videos, or test results):

Paste screenshots or video links here

Related Issues

Closes #


AI Disclosure

  • This PR was authored entirely by me
  • This PR includes AI-generated code (e.g., from GitHub Copilot, ChatGPT)
    • If yes, I have reviewed all AI-generated code for correctness
    • If yes, please describe which parts were AI-assisted:

Whole thing


Merge Checklist

Additional Checks (if applicable)

  • User-facing changes? User documentation is updated
  • Breaking changes? Migration guide is included in description and migrations are marked with // MIGRATION: <dataYear> where <dataYear> is the last season the pre-migration data was used in
  • Bug fix? Regression test is added
  • New dependency? License compatibility is verified and steps have been taken to follow it
  • Serde changes? All messages are regenerated with no unexpected hash changes
  • Configuration changes? Changes are backwards compatible with previous season's last release
  • Pipeline/data exchange changes? Frontend types are updated in ./photon-client/src/types

@github-actions github-actions Bot added the frontend Having to do with PhotonClient and its related items label Aug 24, 2026
@samfreund
samfreund marked this pull request as ready for review August 31, 2026 21:53
@samfreund
samfreund requested a review from a team as a code owner August 31, 2026 21:53
@samfreund
samfreund merged commit d8e4e63 into PhotonVision:main Sep 1, 2026
56 checks passed
@spacey-sooty
spacey-sooty deleted the v-banner-v-alert branch September 1, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants