Skip to content

fix(tooltip): 修复部分情况下 ToolTip 不显示的问题，并调整了偏移量 #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Big-Cake-jpg merged 5 commits into from
Oct 4, 2026
Merged

fix(tooltip): 修复部分情况下 ToolTip 不显示的问题，并调整了偏移量 #3508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d934ee
fix(tooltip): Tooltip 在部分情况下可能不会显示
Pigeon0v0 Aug 6, 2026
755fd30
fix flyout place
Pigeon0v0 Aug 6, 2026
9e0b2c0
调整一些莫名其妙的偏移
Pigeon0v0 Aug 6, 2026
a0b5841
Merge branch 'dev' into fix/tooltip
Pigeon0v0 Oct 4, 2026
6ba26ed
fix: radiobox margin
Big-Cake-jpg Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions PCL.Core/UI/Controls/Tooltip.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,20 @@ private static void OnOpening(object s, ToolTipEventArgs e)
_Hush();
return;
}

if (fe.IsEnabled)
{
if (ReferenceEquals(_target, fe) && _flyout is { IsOpen: true })
return;

if (fe.IsEnabled) return;
if (!ReferenceEquals(_target, fe)) _Hush();
_target = fe;
_latch?.Stop();
_latch = null;
_cursor = Mouse.GetPosition(fe);
_PopUp(fe, _cursor);
return;
}

if (!ReferenceEquals(_target, fe)) _Hush();
_target = fe;
Expand Down Expand Up @@ -307,9 +319,7 @@ private static void _TryClaim(FrameworkElement pivot)
_Hush();
return;
}

if (_closing) return;


_StartCycle(candidate, Mouse.GetPosition(candidate));
}

Expand Down Expand Up @@ -354,6 +364,14 @@ private static bool _PointInside(FrameworkElement el, Point p) =>
private static bool _ShareAncestor(DependencyObject a, DependencyObject b)
{
if (ReferenceEquals(a, b)) return true;

if (a is ComboBox comboA && b is ComboBoxItem itemB &&
ItemsControl.ItemsControlFromItemContainer(itemB) == comboA)
return true;
if (b is ComboBox comboB && a is ComboBoxItem itemA &&
ItemsControl.ItemsControlFromItemContainer(itemA) == comboB)
return true;

for (var cur = VisualTreeHelper.GetParent(b); cur is not null; cur = VisualTreeHelper.GetParent(cur))
if (ReferenceEquals(cur, a)) return true;
for (var cur = VisualTreeHelper.GetParent(a); cur is not null; cur = VisualTreeHelper.GetParent(cur))
Expand Down Expand Up @@ -565,10 +583,10 @@ private static void _PlaceNear(FrameworkElement target, Point pt)

if (mode is PlacementMode.Mouse)
{
_flyout.Placement = PlacementMode.Relative;
_flyout.Placement = PlacementMode.Left;
_flyout.PlacementRectangle = default;
_flyout.HorizontalOffset = Math.Round(pt.X + 15 + ToolTipService.GetHorizontalOffset(target));
_flyout.VerticalOffset = Math.Round(pt.Y + 25 + ToolTipService.GetVerticalOffset(target));
_flyout.VerticalOffset = Math.Round(pt.Y + 15 + ToolTipService.GetVerticalOffset(target));
Comment thread
Big-Cake-jpg marked this conversation as resolved.
}
else if (mode is PlacementMode.MousePoint)
{
Expand Down
5 changes: 0 additions & 5 deletions Plain Craft Launcher 2/Application.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,11 +567,6 @@
</Style>
<Style TargetType="ComboBoxItem" x:Key="MyComboBoxItem">
<Setter Property="OverridesDefaultStyle" Value="True" />
<Setter Property="ToolTipService.Placement" Value="Relative" />
<Setter Property="ToolTipService.VerticalOffset" Value="-2" />
<Setter Property="ToolTipService.HorizontalOffset" Value="200" />
<Setter Property="ToolTipService.InitialShowDelay" Value="150" />
<Setter Property="ToolTipService.BetweenShowDelay" Value="150" />
<Setter Property="FocusVisualStyle" Value="{x:Null}" />
<Setter Property="Background" Value="{DynamicResource ColorBrushTransparent}" />
<Setter Property="Template">
Expand Down
4 changes: 1 addition & 3 deletions Plain Craft Launcher 2/Pages/PageDownload/Comp/MyCompItem.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@
</StackPanel>
<TextBlock x:Name="LabInfo" Grid.Row="2" Grid.Column="4" VerticalAlignment="Center" Margin="0,0,3,0.5"
TextTrimming="CharacterEllipsis" FontSize="12" Foreground="{StaticResource ColorBrushGray3}"
IsHitTestVisible="True" SnapsToDevicePixels="False" UseLayoutRounding="False"
ToolTipService.InitialShowDelay="100" ToolTipService.BetweenShowDelay="100"
ToolTipService.Placement="Relative" ToolTipService.PlacementRectangle="-16,-10,500,10000">
IsHitTestVisible="True" SnapsToDevicePixels="False" UseLayoutRounding="False">
<TextBlock.ToolTip>
<ToolTip x:Name="ToolTipInfo" />
</TextBlock.ToolTip>
Expand Down
13 changes: 3 additions & 10 deletions Plain Craft Launcher 2/Pages/PageInstance/PageInstanceSetup.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@
Tag="VersionRamType/0"
Margin="0,0,20,9"
ToolTip="{DynamicResource Setup.Launch.Memory.Auto.ToolTip}"
ToolTipService.Placement="Right"
ToolTipService.Placement="Left"
ToolTipService.HorizontalOffset="-10"
ToolTipService.VerticalOffset="-3" />
ToolTipService.VerticalOffset="-10" />

<local:MyRadioBox
Grid.Row="2" Grid.Column="0"
Expand Down Expand Up @@ -387,40 +387,33 @@
Text="{DynamicResource Instance.Setup.Advanced.IgnoreJavaCompatibility}"
x:Name="CheckAdvanceJava"
Tag="VersionAdvanceJava"
ToolTipService.Placement="Right"
ToolTip="{DynamicResource Instance.Setup.Advanced.IgnoreJavaCompatibility.ToolTip}" />
<local:MyCheckBox Height="28"
Text="{DynamicResource Instance.Setup.Advanced.DisableFileVerification}"
x:Name="CheckAdvanceAssetsV2"
Tag="VersionAdvanceAssetsV2" Margin="0,0,60,0"
ToolTipService.Placement="Right"
ToolTip="{DynamicResource Instance.Setup.Advanced.DisableFileVerification.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Instance.Setup.Advanced.UseGlobalProxy}"
x:Name="CheckAdvanceUseProxyV2"
Tag="VersionAdvanceUseProxyV2"
ToolTipService.Placement="Right"
ToolTip="{DynamicResource Instance.Setup.Advanced.UseGlobalProxy.ToolTip}" />
<local:MyCheckBox Height="28"
Text="{DynamicResource Setup.Launch.Advanced.DisableJlw}"
x:Name="CheckAdvanceDisableJLW"
Tag="VersionAdvanceDisableJLW"
ToolTipService.Placement="Right"
ToolTip="{DynamicResource Setup.Launch.Advanced.DisableJlw.ToolTip}" />
<local:MyCheckBox Height="28"
Text="{DynamicResource Setup.Launch.Advanced.DisableLF}"
x:Name="CheckAdvanceDisableLF"
Tag="VersionAdvanceDisableLF"
ToolTipService.Placement="Right"
ToolTip="{DynamicResource Setup.Launch.Advanced.DisableLF.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Instance.Setup.Advanced.UseDebugLog4j}"
x:Name="CheckUseDebugLog4j2Config"
Tag="VersionUseDebugLog4j2Config"
ToolTipService.Placement="Right" />
Tag="VersionUseDebugLog4j2Config" />
<local:MyCheckBox Height="28"
Text="{DynamicResource Setup.Launch.Advanced.DisableLwjglUnsafeAgent}"
x:Name="CheckAdvanceDisableLwjglUnsafeAgent"
Tag="VersionAdvanceDisableLwjglUnsafeAgent"
ToolTipService.Placement="Right"
ToolTip="{DynamicResource Setup.Launch.Advanced.DisableLwjglUnsafeAgent.ToolTip}" />
</StackPanel>
</Grid>
Expand Down
20 changes: 10 additions & 10 deletions Plain Craft Launcher 2/Pages/PageSetup/PageSetupLaunch.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@
</Grid.RowDefinitions>
<local:MyRadioBox Text="{DynamicResource Setup.Launch.Memory.Auto}" Width="110" Checked="True" x:Name="RadioRamType0"
Tag="LaunchRamType/0" Margin="0,0,20,9" Check="RadioBoxChange"
ToolTip="{DynamicResource Setup.Launch.Memory.Auto.ToolTip}" ToolTipService.Placement="Right"
ToolTipService.HorizontalOffset="-10" ToolTipService.VerticalOffset="-3" />
ToolTip="{DynamicResource Setup.Launch.Memory.Auto.ToolTip}" ToolTipService.Placement="Left"
ToolTipService.HorizontalOffset="-10" ToolTipService.VerticalOffset="-10" />
<local:MyRadioBox Grid.Row="1" Text="{DynamicResource Common.Option.Customize}" x:Name="RadioRamType1" Tag="LaunchRamType/1"
Margin="0,0,20,9" Check="RadioBoxChange" />
<TextBlock Grid.Row="2" Text="{DynamicResource Setup.Launch.Memory.Max}" VerticalAlignment="Center" Margin="0,0,20,9"
Expand Down Expand Up @@ -270,7 +270,7 @@
<TextBlock Text="{DynamicResource Setup.Launch.Advanced.JvmHead}" VerticalAlignment="Center" />
<local:MyIconButton Height="23" Margin="0,1,0,0" x:Name="BtnAdvanceJvmReset"
VerticalAlignment="Center" Click="BtnAdvanceJvmReset_Click"
ToolTip="{DynamicResource Setup.Launch.Advanced.JvmHead.Restore}" ToolTipService.Placement="Right"
ToolTip="{DynamicResource Setup.Launch.Advanced.JvmHead.Restore}" ToolTipService.Placement="Left"
ToolTipService.InitialShowDelay="200" ToolTipService.VerticalOffset="-1"
SvgIcon="lucide/rotate-ccw"
LogoScale="0.9" />
Expand Down Expand Up @@ -298,19 +298,19 @@
Text="{DynamicResource Setup.Launch.Advanced.PreLaunchCommand.Wait}" Margin="0,8,0,7" />
<StackPanel Margin="0,12,0,4" Grid.Row="8" Grid.ColumnSpan="2" HorizontalAlignment="Left">
<local:MyCheckBox Height="28" Text="{DynamicResource Setup.Launch.Advanced.DisableJlw}" x:Name="CheckAdvanceDisableJLW" Tag="LaunchAdvanceDisableJLW" Change="CheckBoxChange"
ToolTipService.Placement="Right" ToolTip="{DynamicResource Setup.Launch.Advanced.DisableJlw.ToolTip}" />
ToolTip="{DynamicResource Setup.Launch.Advanced.DisableJlw.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Setup.Launch.Advanced.DisableLF}" x:Name="CheckAdvanceDisableLF" Tag="LaunchAdvanceDisableLF" Change="CheckBoxChange"
ToolTipService.Placement="Right" ToolTip="{DynamicResource Setup.Launch.Advanced.DisableLF.ToolTip}" />
ToolTip="{DynamicResource Setup.Launch.Advanced.DisableLF.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Setup.Launch.Advanced.GpuPreference}" x:Name="CheckAdvanceGraphicCard" Tag="LaunchAdvanceGraphicCard" Change="CheckBoxChange"
ToolTipService.Placement="Right" ToolTip="{DynamicResource Setup.Launch.Advanced.GpuPreference.ToolTip}" />
ToolTip="{DynamicResource Setup.Launch.Advanced.GpuPreference.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Setup.Launch.Advanced.UseJavaExe}" x:Name="CheckAdvanceNoJavaw" Tag="LaunchAdvanceNoJavaw" Change="CheckBoxChange"
ToolTipService.Placement="Right" ToolTip="{DynamicResource Setup.Launch.Advanced.UseJavaExe.ToolTip}" />
ToolTip="{DynamicResource Setup.Launch.Advanced.UseJavaExe.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Setup.Launch.Advanced.DisableLwjglUnsafeAgent}" x:Name="CheckAdvanceDisableLwjglUnsafeAgent" Tag="LaunchAdvanceDisableLwjglUnsafeAgent" Change="CheckBoxChange"
ToolTipService.Placement="Right" ToolTip="{DynamicResource Setup.Launch.Advanced.DisableLwjglUnsafeAgent.ToolTip}" />
ToolTip="{DynamicResource Setup.Launch.Advanced.DisableLwjglUnsafeAgent.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Setup.Launch.Advanced.DisableCrashAnalysis}" x:Name="CheckAdvanceDisableCrashAnalysis" Tag="LaunchAdvanceDisableCrashAnalysis" Change="CheckBoxChange"
ToolTipService.Placement="Right" ToolTip="{DynamicResource Setup.Launch.Advanced.DisableCrashAnalysis.ToolTip}" />
ToolTip="{DynamicResource Setup.Launch.Advanced.DisableCrashAnalysis.ToolTip}" />
<local:MyCheckBox Height="28" Text="{DynamicResource Setup.Launch.Advanced.LockMemory}" x:Name="CheckAdvanceLockMemory" Tag="LaunchAdvanceLockMemory" Change="CheckBoxChange"
ToolTipService.Placement="Right" ToolTip="{DynamicResource Setup.Launch.Advanced.LockMemory.ToolTip}" />
ToolTip="{DynamicResource Setup.Launch.Advanced.LockMemory.ToolTip}" />
</StackPanel>
<local:MyHint Text="{DynamicResource Setup.Launch.Advanced.MoreInInstanceSetup}" Margin="0,5,0,10" Theme="Blue" Grid.Row="9"
Grid.ColumnSpan="2"
Expand Down
Loading