Skip to content

fix(client): ignore stale dashboard details - #2836

Open
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/dashboard-detail-latest-request
Open

HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/dashboard-detail-latest-request

Conversation

@HandSonic

@HandSonic HandSonic commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Related issue

N/A - no matching issue was found.

Summary

Dashboard detail loads committed every response. Rapid A-to-B selection could let a slower A response overwrite the already selected B dashboard, and an older success could also commit after the latest request failed. This change assigns generation ownership to detail loads and invalidates pending details when the current dashboard is set directly.

Affected surfaces

  • Frontend / Web
  • Backend / API / Storage
  • Database plugin / Driver
  • JCEF / Desktop packaging
  • CI / Build / Release
  • Documentation only

Verification

  • Commands and results:
    • Deferred ownership tests passed for reverse completion, direct invalidation, and latest failure.
    • Targeted ESLint: passed.
    • Full Community prebuild, Umi/Webpack build, and production bundle verifier: passed.
    • Fork code and CodeQL checks: passed.
    • Merge-tree with the current repair batch: passed.
    • Playwright: delayed B-to-A reverse completion and latest-failure/older-success ordering both preserved A.
  • Manual verification: Passed in the Community dashboard UI with delayed and failed mocked detail responses.
  • UI evidence: N/A

Risk and compatibility

  • Public API or stored data: No API or persisted dashboard format changes.
  • Database or driver compatibility: N/A.
  • Network, privacy, or security: N/A.
  • Community / Local / Pro boundary: Shared Community dashboard store.
  • Backward compatibility: Latest successful loads and direct selection retain existing state shapes.

Reviewer map

  • Start here: DashboardDetailRequestOwner and createCommonAction.getDashboardById.
  • Failure condition: an older response commits after a newer request or direct selection.
  • Rollback or disable path: Revert commit cd1e9f0b03d71b5601b6cc92eafe6fbf57fa9c69; no migration is required.

Contributor declaration

  • I linked the Issue that defines this change.
  • I tested the affected behavior and reported the actual results above.
  • I did not include credentials, private data, or generated build output.
  • I disclosed substantial AI assistance below, or this PR contains no substantial AI-generated code.

AI assistance: OpenAI Codex assisted with diagnosis, implementation, automated tests, verification, and adversarial review.

@HandSonic
HandSonic requested review from a team and openai0229 as code owners August 30, 2026 18:18
@openai0229 openai0229 moved this to In Review in Chat2DB Community Aug 30, 2026
@HandSonic
HandSonic force-pushed the fix/dashboard-detail-latest-request branch 2 times, most recently from 6af9790 to 1f88902 Compare September 3, 2026 16:26
@HandSonic
HandSonic force-pushed the fix/dashboard-detail-latest-request branch from 1f88902 to e7608dc Compare September 3, 2026 16:40

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants