Skip to content

feat(i18n): add Korean translations - #326

Merged
Oppzippy merged 1 commit into
Oppzippy:masterfrom
dicebattle:agent/korean-localization
Aug 5, 2026
Merged

feat(i18n): add Korean translations#326
Oppzippy merged 1 commit into
Oppzippy:masterfrom
dicebattle:agent/korean-localization

Conversation

@dicebattle

@dicebattle dicebattle commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Motivation

This PR adds Korean translations so that OpenSCQ30 can be used naturally in a Korean-language environment. It covers not only the Android app, but also the desktop GUI and the device setting names and values provided by the shared library, reducing the amount of English mixed into the interface.

Changes

  • Added Korean translations for the Android app UI.
  • Added Korean translations for the desktop GUI.
  • Added Korean translations for device setting names and values provided by the shared library.
  • No application behavior or device communication logic was changed.

Validation

  • Confirmed that 83 Android translations, 48 GUI translations, and 233 shared-library translations match the keys in the current English source files.
  • just format-check
  • cargo check -p openscq30-gui
  • ./gradlew testX86_64DebugUnitTest
  • ./gradlew assembleArm64-v8aDebug
  • Android XML syntax validation and git diff --check

This PR was created with the assistance of AI tools.

@dicebattle dicebattle changed the title feat(i18n): 한국어 번역 추가 feat(i18n): add Korean translations Jul 19, 2026
@dicebattle
dicebattle force-pushed the agent/korean-localization branch from 8266b10 to d073879 Compare July 19, 2026 06:27
@Oppzippy

Oppzippy commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Is this ready to merge? Just checking since it's still marked as draft.

@dicebattle
dicebattle marked this pull request as ready for review August 4, 2026 23:18
@dicebattle

Copy link
Copy Markdown
Contributor Author

Sorry for late. I was busy for my daily life.
I don't know other language's translation quality, and actually korean translation quality is based on AI translation, but as a native korean, I think it's quality is pretty good to go.

(honestly, official soundcore app's korean translation has some trouble, so I think it would be better than soundcore app)

@Oppzippy
Oppzippy merged commit 8cda7dd into Oppzippy:master Aug 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants