Repository navigation
spec: OVOS-AUDIO-1 — bridge cite; listen-gating scope; barge-in policy note - #139
Merged
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JarbasAl
marked this pull request as ready for review
August 4, 2026 12:46
JarbasAl
marked this pull request as draft
August 10, 2026 14:24
…y note - §4.3: fix bridge citation OVOS-BRIDGE-1 §4.2.4 → §4.2.5 (TTS as a service) - §4.4: scope listen-flag/ended gating to local-playback path, forward-ref §3.4's remote-client exception - §6: add barge-in-is-deployer-policy paragraph (ovos.listener.wakeword → ovos.audio.stop is optional, not mandated) - §3.2: scope synthesis-failure clause per-segment; state partial-utterance bus contract is limited to §5.2 ended-on-queue-empty - §5.3: note is_speaking is deliberately session-scoped, no aggregate query
JarbasAl
force-pushed
the
spec/audio-out-audit
branch
from
August 10, 2026 18:17
1cebab4 to
f1bd400
Compare
JarbasAl
marked this pull request as ready for review
August 13, 2026 00:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: normative fix —
audio-out.mdWhat
ovos.audio.output.endedfires once the queue empties.listengating onovos.audio.output.endedis scoped to the local-playback path; the remote-client path keeps §3.4's immediate emission.is_speakingis deliberately session-scoped; no aggregate query exists.Why (defect citation)
ovos.mic.listenafterovos.audio.output.endedfor any Message carryinglisten: true.ovos.utterance.speak.b64never enters the scheduled queue and so never reaches that event — §3.4 already defines the exception, and §4.4 contradicted it.Semantic change?
No — it states which of two existing rules governs each path.
Owner decision needed?
No.
Depends on
Nothing.
No
version:field bump and no CHANGELOG entry: the specs are unreleased and all one version.