Skip to content

spec: INTENT-1 — single-branch groups degenerate not malformed, structural adjacency check, timeless scoping - #116

Open
JarbasAl wants to merge 1 commit into
devfrom
spec/intent-1
Open

spec: INTENT-1 — single-branch groups degenerate not malformed, structural adjacency check, timeless scoping#116
JarbasAl wants to merge 1 commit into
devfrom
spec/intent-1

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Jul 4, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Fable 5 (claude-fable-5) via Claude Code — NOT human-reviewed. Verify before acting. Cross-spec citations were model-verified against dev source; behavior-change sections need owner judgment.

Consistency and design review of OVOS-INTENT-1 (Sentence Template Grammar).

Original PR content (unchanged hunks)

  • §3.2/§3.6 — a single-branch group (word) is degenerate, not malformed: loaders MUST accept it, SHOULD warn, and MUST fold it to the bare branch; only the empty () remains malformed.
  • §3.6 — structural (pre-expansion) adjacent-slot detection admitted as a conformant alternative to full-expansion checking, when it accepts/rejects exactly the same templates.
  • §2/§5.3 — normalization and slot-typing restated as timeless out-of-scope statements.
  • §7 — planned-conformance-corpus sentence removed.
  • §4.2 — step-number citation corrected.
  • See also — resource-role count corrected (six roles, five template-bearing).

Follow-up commit (audit findings not covered above)

BLOCKER — §6.2 mis-scoped .dialog as engine training data. §6.2 step 3
required engines to verify .dialog slot consistency, and step 5 described
all data reaching §6 as "match-time-filled" — both contradict §5.1, which
defines .dialog slots as caller-filled before rendering, not engine-filled
at match time. No intent engine trains on .dialog. Fixed by scoping §6
(training-data contract) to the input-direction, engine-trained roles only —
.intent, .entity, .voc, .blacklist — and moving the dialog-consumer
intake obligation (reading the file/inline phrases) into §7's existing
Dialog renderer bullet, which already owns slot-set verification and fill
discipline for .dialog.

MAJOR — §5.5 cited an undefined wire contract. §5.5 pointed to §6.1 for
"inline caller-supplied-fill phrases registered together," but §6.1 only
ever defined delivery for .intent/.entity (and by extension .voc/
.blacklist) — it never defined a registration mechanism for .dialog.
Dropped the dangling (§6.1) citation and rephrased §5.5 to define the
one-dialog unit on its own terms, without implying this spec specifies a
wire contract for dialog delivery (it doesn't, and that's fine — a renderer-
or host-application-specific concern).

Both fixes are additive text-scoping changes; no normative requirement on
.intent/.entity/.voc/.blacklist or the existing .dialog fill rules
in §5.1/§7 changed.

CHANGELOG entry extended accordingly. Still draft; rebased clean onto
current dev.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ebceb1d-ee6e-44f7-94ae-1dadc028661f

📥 Commits

Reviewing files that changed from the base of the PR and between 1d3622b and 1117221.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • intent-1.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spec/intent-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl
JarbasAl marked this pull request as ready for review July 16, 2026 07:21
@JarbasAl
JarbasAl marked this pull request as draft July 24, 2026 02:08
@JarbasAl
JarbasAl marked this pull request as ready for review August 4, 2026 12:46
…tural adjacency check, timeless scoping

Squashed from:
- spec: OVOS-INTENT-1 — scope §6 to grammar roles; drop dead §5.5 dialog-registration citation
- docs: INTENT-1 consistency and design review — degenerate single-branch groups, structural adjacency, timeless scoping

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant