Ci speedup#1259
Open
MattiSG wants to merge 4 commits into
Open
Conversation
Decrease risks with flaky tests, decrease consumption, speed up CI Engine tests should be cross-platform, but smoke-testing downstream dependencies does not need to be cross-platform
Instead of oldest supported Node version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1258.
Speedup and failure rate decrease by stopping to run integration tests cross-platform
This changeset stops running metadata and declaration validation on macOS and Windows. This is based on the idea that engine tests definitely should be cross-platform, but smoke-testing downstream dependencies does not need to be cross-platform: cross-platform behavioural consistency is guaranteed by the engine tests, integration testing is not necessary cross-platform. If this hypothesis does not hold in production and we get defect reports, we can revert this changeset.
Expected speedup: at least 1 minute per run (18% speedup), up to 2m30 (40%) per run.
Indeed, Windows runs around ~1m15 for both metadata and declarations validation, while macOS and Ubuntu run in around ~42s.
With perfect parallelism, that's 2 x 30s saved; with totally failing parallelism, that's 2 x 75s saved. The reality will probably be somewhere in between.
Preliminary run result shows no evident speed gain (5m17s, the lowest in the range of previous runs but still in the same range).
Test cross-platform on Node latest instead of oldest
For some reason, we were testing on macOS and Windows only on the oldest supported version of Node instead of the most recent. This changeset inverts that behaviour.