Skip to content

Validate unique combine fetch#1254

Merged
clementbiron merged 3 commits into
mainfrom
validate-unique-combine-fetch
Jun 29, 2026
Merged

Validate unique combine fetch#1254
clementbiron merged 3 commits into
mainfrom
validate-unique-combine-fetch

Conversation

@clementbiron

Copy link
Copy Markdown
Member

A combine can currently repeat the same fetch URL within a terms type, which causes redundant fetches. npm run declarations:validate now rejects it and reports the duplicated URL(s). The same fetch stays allowed across different terms types.

@clementbiron clementbiron requested a review from Ndpnt June 23, 2026 12:51
@clementbiron clementbiron force-pushed the validate-unique-combine-fetch branch from 6efa7b2 to 661c9b0 Compare June 23, 2026 13:13
@clementbiron clementbiron force-pushed the validate-unique-combine-fetch branch from 661c9b0 to f9c458e Compare June 23, 2026 13:20
@clementbiron clementbiron merged commit a088663 into main Jun 29, 2026
14 checks passed
@clementbiron clementbiron deleted the validate-unique-combine-fetch branch June 29, 2026 07:43
@MattiSG

MattiSG commented Jun 29, 2026

Copy link
Copy Markdown
Member

This change removes the ability to insert a subset of page A, then page B, then another subset of page A.
There is no clear use case for this.
There is however a clear cost, and a recurring problem, with duplicating documents in a combine.
This is worthwhile; if in the future we find a clear use case for inserting pages in-between one page, we can reconsider this decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants