Validate unique combine fetch#1254
Merged
Merged
Conversation
Ndpnt
approved these changes
Jun 23, 2026
6efa7b2 to
661c9b0
Compare
661c9b0 to
f9c458e
Compare
Member
|
This change removes the ability to insert a subset of page A, then page B, then another subset of page A. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A combine can currently repeat the same fetch URL within a terms type, which causes redundant fetches.
npm run declarations:validatenow rejects it and reports the duplicated URL(s). The same fetch stays allowed across different terms types.