Skip to content

Fix cross-screen state isolation and element restoration - #99

Merged
veillette merged 1 commit into
mainfrom
cursor/fix-review-findings-9aef
Sep 5, 2026
Merged

Fix cross-screen state isolation and element restoration#99
veillette merged 1 commit into
mainfrom
cursor/fix-review-findings-9aef

Conversation

@veillette

@veillette veillette commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • scope keyboard shortcuts and undo history to the visible screen
  • filter track snapping to the active screen’s registered tracks
  • synchronize PhET-iO element replacement with scene lookup, trace invalidation, and view reconstruction
  • advance generated IDs beyond restored sparse IDs and reject duplicate IDs
  • add regression coverage for all four findings

Testing

  • npm test — 421 tests passed
  • npm run check — passed
  • npm run lint — passed
  • npm run build — passed, including PWA generation
  • manually verified one-step undo and keyboard/grid isolation across Lab and Intro

Walkthrough

screen_isolation_and_single_step_undo.mp4

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@veillette
veillette marked this pull request as ready for review September 5, 2026 00:55
@veillette
veillette merged commit 9f15cf3 into main Sep 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants