fix(catalog): favor Notion OAuth connection option#379
Merged
Conversation
Notion's catalog entry listed the api_key (stdio MCP) option first and the OAuth2 option second. integrations-hub builds each visible connector from connectionOptions[0], so Notion surfaced as an api_key connector and its OAuth option was silently dropped — unlike Slack and Linear, which list oauth first. Reorder the options so oauth comes first (favored) and the api_key stdio MCP option remains as a fallback, matching the Slack/Linear convention.
Contributor
|
🚀 Released in v0.8.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
integrations-hub, Slack and Linear surface as OAuth connectors, but Notion does not — it shows as anapi_keyconnector.Root cause
integrations/catalog/notion.jsonlisted two connection options with theapi(api_key / stdio MCP) option first and theoauth(OAuth2 / HTTP) option second:integrations-hubbuilds each visible connector from only the first connection option (integration.connectionOptions[0]insrc/lib/integrations/integration-catalog.ts), so Notion surfaced as anapi_keyconnector and its OAuth option was silently dropped. Slack and Linear both listoauthfirst, which is why they show as OAuth connectors.Fix
Reorder
notion.jsonso theoauthoption comes first (favored) and theapi_keystdio MCP option remains as a fallback — matching the Slack/Linear convention. Both options are retained; only the order changes.Verification
["oauth", "api"], first auth strategyoauth2.test_catalogs.py,test_catalog_schema.py,test_integration_catalog_in_sync.py).This is a catalog-data-only change (no code, no schema change). Once merged, release-please will fold it into the queued
0.8.0release PR (#377).This PR was created by an AI agent (OpenHands) on behalf of @neubig.