Skip to content

fix(catalog): favor Notion OAuth connection option#379

Merged
neubig merged 1 commit into
mainfrom
fix/notion-oauth-favored
Jun 30, 2026
Merged

fix(catalog): favor Notion OAuth connection option#379
neubig merged 1 commit into
mainfrom
fix/notion-oauth-favored

Conversation

@neubig

@neubig neubig commented Jun 30, 2026

Copy link
Copy Markdown
Member

Problem

In integrations-hub, Slack and Linear surface as OAuth connectors, but Notion does not — it shows as an api_key connector.

Root cause

integrations/catalog/notion.json listed two connection options with the api (api_key / stdio MCP) option first and the oauth (OAuth2 / HTTP) option second:

"connectionOptions": [
  { "id": "api",   "auth": { "strategy": "api_key" } },  // first → used
  { "id": "oauth", "auth": { "strategy": "oauth2" } }    // second → ignored
]

integrations-hub builds each visible connector from only the first connection option (integration.connectionOptions[0] in src/lib/integrations/integration-catalog.ts), so Notion surfaced as an api_key connector and its OAuth option was silently dropped. Slack and Linear both list oauth first, which is why they show as OAuth connectors.

Fix

Reorder notion.json so the oauth option comes first (favored) and the api_key stdio MCP option remains as a fallback — matching the Slack/Linear convention. Both options are retained; only the order changes.

Verification

  • JSON validated; option order is now ["oauth", "api"], first auth strategy oauth2.
  • Ran the catalog test suite: 95 passed (test_catalogs.py, test_catalog_schema.py, test_integration_catalog_in_sync.py).
  • No test asserts the previous ordering.

This is a catalog-data-only change (no code, no schema change). Once merged, release-please will fold it into the queued 0.8.0 release PR (#377).

This PR was created by an AI agent (OpenHands) on behalf of @neubig.

Notion's catalog entry listed the api_key (stdio MCP) option first and
the OAuth2 option second. integrations-hub builds each visible connector
from connectionOptions[0], so Notion surfaced as an api_key connector
and its OAuth option was silently dropped — unlike Slack and Linear,
which list oauth first.

Reorder the options so oauth comes first (favored) and the api_key
stdio MCP option remains as a fallback, matching the Slack/Linear
convention.
@github-actions github-actions Bot added the type: fix A bug fix label Jun 30, 2026
@neubig neubig merged commit f2733f3 into main Jun 30, 2026
6 checks passed
@neubig neubig deleted the fix/notion-oauth-favored branch June 30, 2026 04:01
@openhands-release-bot

Copy link
Copy Markdown
Contributor

🚀 Released in v0.8.0.

@openhands-release-bot openhands-release-bot Bot added the released: v0.8.0 Shipped in v0.8.0 label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released: v0.8.0 Shipped in v0.8.0 type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants