Improve CI by running Clippy directly and locking dependencies - #46
Merged
Merged
Conversation
Run Clippy directly and track workspace lockfiles so local and hosted checks resolve the same dependency versions. Raise the MSRV to 1.93 and fix the stable Clippy diagnostics. Keep the feature matrix compatible with cargo-batch's supported arguments. Assisted-by: GitHub Copilot:gpt-5.3-codex
jerrysxie
force-pushed
the
fixing-workflow
branch
from
August 20, 2026 04:14
af2203e to
945efa8
Compare
jerrysxie
marked this pull request as ready for review
August 20, 2026 04:23
jerrysxie
requested review from
kurtjd,
tullom and
williampMSFT
and
a lite review from Copilot
and removed request for
Copilot
August 20, 2026 04:23
There was a problem hiding this comment.
Pull request overview
Improves CI reproducibility with committed lockfiles and locked Cargo commands, while simplifying Clippy execution and command handling.
Changes:
- Commits workspace lockfiles and updates ignore rules.
- Runs Clippy directly, locks CI dependency resolution, and raises MSRV to 1.93.
- Boxes nested download commands and applies minor cleanup.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/check.yml |
Updates Clippy, locked commands, and MSRV. |
libs/ci.sh |
Adjusts generated build-command indentation. |
libs/Cargo.lock |
Locks library workspace dependencies. |
libs/.gitignore |
Allows the library lockfile. |
examples/rt685s/Cargo.lock |
Locks example workspace dependencies. |
examples/rt685s/.gitignore |
Allows the example lockfile. |
bootloader-tool/src/processors/otp.rs |
Removes an unnecessary borrow. |
bootloader-tool/src/lib.rs |
Boxes flattened run commands. |
bootloader-tool/src/commands/download.rs |
Unboxes commands before processing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RobertZ2011
previously approved these changes
Aug 20, 2026
felipebalbi
reviewed
Aug 20, 2026
Restore beta to the Clippy toolchain matrix and document why Rust 1.93 is the minimum supported version.
Replace the unchecked slice conversion with as_chunks so beta Clippy accepts the state parser without changing remainder handling. Assisted-by: GitHub Copilot:gpt-5.3-codex
kurtjd
previously approved these changes
Aug 20, 2026
felipebalbi
previously approved these changes
Aug 20, 2026
Use fixed-size slice chunks for hexadecimal parsing and integer conversion so the beta style lint passes without changing remainder handling. Assisted-by: GitHub Copilot:claude-opus-4.6
kurtjd
approved these changes
Aug 20, 2026
felipebalbi
approved these changes
Aug 20, 2026
alamfarjadf
pushed a commit
to alamfarjadf/ec-slimloader
that referenced
this pull request
Aug 26, 2026
…evicePartnership#46) - Replace the silently passing clippy GH action with direct calls to clippy - Fix all the clippy warnings that came up - Lock down dependencies by checking Cargo.lock into source control and add `--locked` flag to all CI workflows where it is applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--lockedflag to all CI workflows where it is applicable