Various fixups for docker-build-release#7
Conversation
- Removed the duplicate `actions/attest-build-provenance@v3` step. The `docker/build-push-action@v6` already generates provenance and SBOM attestations that work correctly with multi-arch manifest lists. - Use conditional expression to only pass CC when it's not empty - Added Image Description Support Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
Signed-off-by: Alex Lovell-Troy <alovelltroy@lanl.gov>
rainest
left a comment
There was a problem hiding this comment.
CI is busted, but AFAICT we're stuck using test repos to properly test here anyway.
To that end: https://github.com/rainest/power-control/actions/runs/26782021013
The unknown/unknown thing is still there. That's apparently a GitHub bug that they can't be bothered to fix per https://github.com/orgs/community/discussions/45969
Discussion lists disabling attestations as a workaround, but we do want those, and it looks like the phantom OS/arch entry is otherwise benign, so 🤷
Also GitHub has helpfully dumped a spoopy "Node update's coming oh no 👻 " warning that you can't actually clear even if you test with it on: see https://github.com/orgs/community/discussions/190988 and https://github.com/rainest/power-control/actions/runs/26782487730
actions/attest-build-provenance@v3step. Thedocker/build-push-action@v6already generates provenance and SBOM attestations that work correctly with multi-arch manifest lists.For more info, see Contributing Guidelines.