fix(signature): realigning SignatureManager with specs (#284)#290
fix(signature): realigning SignatureManager with specs (#284)#290guzmud wants to merge 5 commits into
Conversation
|
🤖 [AI-generated] Hey @guzmud! 👋 Thanks a lot for opening PR #290 — really appreciate the contribution to OpenAEV! 🙏 I just had a quick look and I think the description could be enhanced a little to help reviewers get through it faster. I haven't changed anything in your description — just a gentle, optional suggestion:
No rush at all — thanks again for contributing to the project! 🚀 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 73.19% 73.23% +0.04%
==========================================
Files 53 53
Lines 2350 2361 +11
==========================================
+ Hits 1720 1729 +9
- Misses 630 632 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Proposed changes
/api/injects/execution/callback/{injectId}as the targeted endpointSignatureTargetmodelInjectExecutionActions(mirroring https://github.com/OpenAEV-Platform/openaev/blob/bba8f2f2180f1a789f7be84144bc2562b62b93e6/openaev-api/src/main/java/io/openaev/rest/inject/form/InjectExecutionAction.java#L3) for the POST outer envelopeexecution_actionSignatureOutputStructureto validate the json dumped string that will be in the updatedSignatureCallbackPayloadexecution_output_structuredto the POST outer envelope (typing:strbut actually a json dumps ofSignatureOutputStructure)SignatureOutputStructure, fill it, then serialize it as astrand feed it into theSignatureCallbackPayloadexecution_messageto the POST outer envelope (typing:str) and fill it using ...?execution_statusto the POST outer envelope (typing:str) and fill it using ...?execution_durationto the POST envelope (based on thestart_timeandend_timesignatures?)Testing Instructions
Related issues
Checklist
Further comments