Skip to content

[csolution-rpc] Clean active target set before loading a solution#2496

Merged
soumeh01 merged 1 commit into
mainfrom
projmgr-clean-active-target-set
Jun 11, 2026
Merged

[csolution-rpc] Clean active target set before loading a solution#2496
soumeh01 merged 1 commit into
mainfrom
projmgr-clean-active-target-set

Conversation

@brondani

@brondani brondani commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Clean active target set before loading a solution, ensuring a previously loaded target set (and its project-context selection) is not inadvertently reused.
  • Add test case.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@brondani brondani marked this pull request as ready for review June 11, 2026 14:39
@brondani brondani requested a review from soumeh01 June 11, 2026 14:39
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.24%. Comparing base (7b35e61) to head (0bcd081).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2496   +/-   ##
=======================================
  Coverage   65.24%   65.24%           
=======================================
  Files         147      147           
  Lines       26674    26675    +1     
  Branches    16166    16166           
=======================================
+ Hits        17404    17405    +1     
  Misses       7071     7071           
  Partials     2199     2199           
Flag Coverage Δ
projmgr-cov 87.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/include/ProjMgrWorker.h 83.87% <100.00%> (+0.53%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Test Results

    3 files     21 suites   20m 36s ⏱️
  467 tests   467 ✅ 0 💤 0 ❌
1 401 runs  1 401 ✅ 0 💤 0 ❌

Results for commit 0bcd081.

@soumeh01 soumeh01 merged commit 859cb6c into main Jun 11, 2026
33 checks passed
@soumeh01 soumeh01 deleted the projmgr-clean-active-target-set branch June 11, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants