Fix VT working set and application SonarQube warnings#699
Merged
sujandumaru merged 1 commit intoJun 26, 2026
Merged
Conversation
ad3154
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR reduces SonarQube findings in the Virtual Terminal working-set parser and seeder example while preserving C++11 compatibility.
Changes include:
Verified SonarQube improvements:
isobus_virtual_terminal_working_set_base.cpp: 271 → 53 issuesvt_application.cpp: 10 → 6 issuesThe remaining findings generally require broader refactoring and are outside this PR's scope. This work is intended to improve the SonarQube reliability rating from C to A and pass the SonarQube analysis quality gate.
How has this been tested?
The modified files were rescanned using SonarQube for IDE. The project and complete unit-test suite were also run locally:
cmake --build build --target unit_tests cd build ./test/unit_tests