Execute overlay renderer in source frame#30
Merged
Conversation
lukasopacity
force-pushed
the
lukas/exec-iframe
branch
from
2eac866 to
e8824f0
Compare
lukasopacity
commented
Jun 2, 2026
|
|
||
| #if DEBUG | ||
| if (@available(iOS 16.4, *)) { | ||
| self.webView.inspectable = YES; |
Collaborator
Author
There was a problem hiding this comment.
lets me using dev tools while the app is running, useful for debugging overlay
adrianopacity
approved these changes
Jun 2, 2026
adrianopacity
left a comment
adrianopacity
left a comment
Collaborator
There was a problem hiding this comment.
Honestly looks good, as long as you ve tested on at least one past flow that uses the browser.eval_js
adrianopacity
approved these changes
Jun 8, 2026
| } | ||
|
|
||
| return opacityStringFromOwnedCString(getter()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Oh so weak attribute didn't work, did it? unlucky
But yeah looks good ig, as long as you tested, all g
Collaborator
There was a problem hiding this comment.
Wait, on android did work but it doesn't work here? Or u forgot to update it here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.