chore(ci): Sign XCFrameworks with OneSignal identity and improve manifest updates#1676
Open
nan-li wants to merge 3 commits into
Open
chore(ci): Sign XCFrameworks with OneSignal identity and improve manifest updates#1676nan-li wants to merge 3 commits into
nan-li wants to merge 3 commits into
Conversation
…nsigned Archive with code signing disabled so the build needs no developer certificate, then sign each inner slice and the wrapper with the OneSignal Apple Distribution identity. Move the framework list into one shared env var and drop the unused dev-cert import. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Run codesign --verify on every slice and wrapper and assert the OneSignal signer, so a missed slice or wrong identity fails the release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Editing by hardcoded line numbers silently corrupted the manifest whenever unrelated lines shifted. Locate each binary target by its framework name and rewrite the url version plus the checksum on the line immediately after it, so a reordered or renamed checksum line can't overwrite a neighbour. Require a version argument and fail loudly on any mismatch rather than corrupting the manifest silently. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fadi-george
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Make the release pipeline robust: archive XCFrameworks unsigned and sign them with the OneSignal identity, verify the signatures, and update Package.swift by target name instead of line number.
Details
Motivation
The release workflow had brittle spots that caused repeated release failures:
Package.swiftwas edited by hardcoded line numbers. When unrelated lines shifted, the generator overwrote binary-target boundaries and produced an unparseable manifest, breaking Swift Package Manager consumers.This makes each step self-healing so releases stop breaking.
Scope
Release tooling only — no SDK runtime code or public API changes.
build_all_frameworks.sh: archive with code signing disabled (no developer cert / team needed).create-release-prs.yml: sign every framework slice and wrapper with the OneSignal Apple Distribution identity; add a verification step that fails the release if anything is unsigned or signed by the wrong identity; drop the unused dev-cert import. The framework list lives in one shared env var.update_swift_package.sh: locate each binary target by framework name and rewrite its url version + checksum in place, with fail-loud guards so a malformed manifest errors instead of silently corrupting.Testing
Manual testing
Validated the scripts locally against the real manifest: signing produces frameworks that pass
codesign --verifyunder the OneSignal identity; the manifest generator reproduces a known-goodPackage.swiftbyte-for-byte and fails loudly on malformed/misordered input instead of corrupting it.